[PATCH] D50958: [clangd] Implement findReferences function
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 5 03:58:21 PDT 2018
sammccall added inline comments.
================
Comment at: clangd/XRefs.cpp:328
+ : AST(AST) {
+ for (const Decl *D : TargetDecls)
+ Targets.insert(D);
----------------
hokein wrote:
> nit: we can initialize TargetDecls like `Targets(TargetDecls.begin(), TargetDecls.end())`.
In fact `SmallSet` is missing this constructor :-(
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50958
More information about the cfe-commits
mailing list