[clang-tools-extra] r341449 - [clangd] Tune macro quality scoring for code completion.

Eric Liu via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 5 00:40:38 PDT 2018


Author: ioeric
Date: Wed Sep  5 00:40:38 2018
New Revision: 341449

URL: http://llvm.org/viewvc/llvm-project?rev=341449&view=rev
Log:
[clangd] Tune macro quality scoring for code completion.

x0.2 seems to be too much penalty, macros might be wanted in some cases;
changing to 0.5x instead. The tuning didn't affect ranking for non-macro
completions.

Modified:
    clang-tools-extra/trunk/clangd/Quality.cpp

Modified: clang-tools-extra/trunk/clangd/Quality.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/Quality.cpp?rev=341449&r1=341448&r2=341449&view=diff
==============================================================================
--- clang-tools-extra/trunk/clangd/Quality.cpp (original)
+++ clang-tools-extra/trunk/clangd/Quality.cpp Wed Sep  5 00:40:38 2018
@@ -221,7 +221,7 @@ float SymbolQualitySignals::evaluate() c
     Score *= 0.8f;
     break;
   case Macro:
-    Score *= 0.2f;
+    Score *= 0.5f;
     break;
   case Unknown:
   case Constructor: // No boost constructors so they are after class types.




More information about the cfe-commits mailing list