[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.
David Blaikie via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 4 16:35:29 PDT 2018
dblaikie added a comment.
In https://reviews.llvm.org/D51554#1224049, @echristo wrote:
> The change in name here from "line tables" to "directives only" feels a bit confusing. "Limited" seems to be a bit more clear, or even remaining line tables only. Can you explain where you were going with this particular set of changes in a bit more detail please?
Can't say I have much of an informed opinion about the parts that are only in the CUDA code. The "line directives only" terminology did come from a suggestion I made in one of the other reviews I can't seem to find right now.. ah, here: https://reviews.llvm.org/D51177 - whether or not that matches up with the use in the CUDA ToolChain code, I'm not sure.
Repository:
rC Clang
https://reviews.llvm.org/D51554
More information about the cfe-commits
mailing list