[PATCH] D51567: CMake: Consolidate gtest detection code
Tom Stellard via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 4 11:51:41 PDT 2018
tstellar added a comment.
In https://reviews.llvm.org/D51567#1222704, @chandlerc wrote:
> I mean, sure.
>
> I really don't know that supporting this ever expanding diversity of build strategies is worth its cost, but I don't see a specific reason to not take this patch....
I actually agree with you that we don't want to be supporting every possible strategy in trunk. I usually try to keep Fedora specific stuff like this out of trunk, but in this case it looked like a useful code simplification that might be generally helpful.
Repository:
rC Clang
https://reviews.llvm.org/D51567
More information about the cfe-commits
mailing list