[PATCH] D51576: Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)

Tue Sep 4 11:20:23 PDT 2018

labath added a comment.

In https://reviews.llvm.org/D51576#1223234, @aprantl wrote:

> This is DWARF5+ only, right? (We shouldn't change the preference of Apple accelerator tables for DWARF 4 and earlier).

The interactions here are a bit weird, but the short answer is no, this will not affect apple tables in any way.

The long answer is: The type of accelerator tables that get generated gets chosen in the back end, based on target triple and dwarf version. If apple tables get chosen, then this patch makes no difference because apple tables ignore the -gpubnames argument. If dwarf tables get chosen, then they will only index the CUs which had the "pubnames" flag set to on (!None). This patch makes it such that we automatically set that flag when tuning for lldb, thereby obtaining the same default behavior as apple tables (indexing all CUs when tuning for lldb).

Repository:
  rC Clang

https://reviews.llvm.org/D51576