[PATCH] D51605: [clangd] SymbolOccurrences -> Refs and cleanup

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 4 04:51:42 PDT 2018


sammccall marked an inline comment as done.
sammccall added inline comments.


================
Comment at: clangd/index/Index.cpp:158
+    auto &SymRefs = Sym.second;
+    std::sort(SymRefs.begin(), SymRefs.end());
+    // TODO: do we really need to dedup?
----------------
lebedev.ri wrote:
> I noticed this by accident, but i'm pretty sure `std::sort()` should not be used in LLVM sources **at all**.
> `llvm::sort()` should be used **everywhere**.
OK, I'll send a cleanup, thanks!


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51605





More information about the cfe-commits mailing list