[PATCH] D51544: [OpenCL] Split opencl-c.h header

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added inline comments.


================
Comment at: lib/Headers/opencl-c-common.h:9
+//===----------------------------------------------------------------------===//
+
+#ifndef __OPENCL_C_COMMON_H__
----------------
Would it be worth having a brief explanation here about what is supposed to go in this file?  Although that merely repeats what's already in opencl-c.h of course.

Or perhaps you could make the description on line 1 more specific to each file.


================
Comment at: lib/Headers/opencl-c.h:23
+///
+///   3. Functions which which satisfy (2), but require fp16 or fp64 support
+///      should go into opencl-c-fp16.h and opencl-c-fp64.h.
----------------
nitpick: double "which"


Repository:
  rC Clang

https://reviews.llvm.org/D51544