[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 3 14:19:45 PDT 2018


phosek added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:4187
 
   SmallString<128> R(ResourceDir);
   llvm::sys::path::append(R, Name);
----------------
mcgrathr wrote:
> You could fold these cases into the lambda too by having it take a bool UseSysRoot and passing `{ResourceDir}, false`.
> Then the main body is a uniform and concise list of paths to check.
I considered that but `llvm::SmallVector` doesn't support initializer list so this ends up looking not so great.


Repository:
  rC Clang

https://reviews.llvm.org/D51573





More information about the cfe-commits mailing list