[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.
UTKARSH SAXENA via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 3 10:59:43 PDT 2018
usaxena95 added a comment.
Applied the changes suggested.
================
Comment at: lib/Basic/VirtualFileSystem.cpp:677
+ if (HardLinkTarget)
+ Child.reset(new detail::InMemoryHardLink(P.str(), *HardLinkTarget));
+ else {
----------------
ilya-biryukov wrote:
> NIT: `.str()` seems redundant
Here P is a Twine here which cannot be converted to StringRef
Repository:
rC Clang
https://reviews.llvm.org/D51359
More information about the cfe-commits
mailing list