[PATCH] D51598: [clangd] Avoid crashes in override completions
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 3 08:03:33 PDT 2018
ilya-biryukov added inline comments.
================
Comment at: unittests/clangd/CodeCompleteTests.cpp:1770
+ // Check the completions call does not crash.
+ completions(R"cpp(
+ struct Base {
----------------
Was wondering if testing for crashes LG this way, or adding more assertions might make sense too
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51598
More information about the cfe-commits
mailing list