[PATCH] D50850: clang: Add triples support for MIPS r6

[Simon Atanasyan via Phabricator via cfe-commits]

atanasyan added a comment.

Could you please include more context to patches sent for review?
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface



================
Comment at: lib/Driver/ToolChains/Linux.cpp:46
       TargetTriple.getEnvironment();
+  llvm::Triple::SubArchType TargetSubArch = TargetTriple.getSubArch();
   bool IsAndroid = TargetTriple.isAndroid();
----------------
Maybe use `bool IsR6` to make the following expressions shorter?


================
Comment at: lib/Driver/ToolChains/Linux.cpp:111
+        (TargetSubArch == llvm::Triple::MipsSubArch_r6) ? "mipsisa32"
+	                                                : "mips";
+    if (D.getVFS().exists(SysRoot + "/lib/" + MipsCpu + "-linux-gnu"))
----------------
clang-format these lines


Repository:
  rC Clang

https://reviews.llvm.org/D50850