[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 31 22:18:20 PDT 2018


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:184
+  size_t Bytes = PairedSlabSize;
+  Bytes += LookupTable.size() * sizeof(std::pair<SymbolID, const Symbol *>);
   Bytes += SymbolQuality.size() * sizeof(std::pair<const Symbol *, float>);
----------------
Why not use `LookupTable.getMemorySize()` directly? Is it intentionally for not counting non-used but allocated buckets? Same for the below two as well.


https://reviews.llvm.org/D51539





More information about the cfe-commits mailing list