[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 31 08:39:17 PDT 2018

kbobyrev added inline comments.

Comment at: clang-tools-extra/clangd/index/dex/Token.h:54
+    /// Path to symbol declaration.
+    ///
ioeric wrote:
> As this is called `Path`, I'd try to decouple it from URIs, so that we don't need special handling of `scheme` etc in the implementation. We might want to canonicalize URI to "path" like `/file:/path/to/something/` so that we could simply treat it as normal paths, and the token could potentially handle actual actual file paths.
Should probably rename it to URI and be more explicit about its nature.


More information about the cfe-commits mailing list