[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 31 06:53:11 PDT 2018

sammccall added a comment.

This looks reasonable!
This is going to conflict with https://reviews.llvm.org/D51422, you might want to rebase.

Comment at: clang-tools-extra/clangd/index/MemIndex.h:26
+  void build(std::shared_ptr<std::vector<const Symbol *>> Symbols,
+             size_t SlabSize=0);
could you make these names somewhat more abstract (e.g. BackingMemory rather than SlabSize)?
The index shouldn't know/care which configuration of slabs it's built from.


More information about the cfe-commits mailing list