[PATCH] D51507: Allow all supportable attributes to be used with #pragma clang attribute.

Kristina Brooks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 30 18:04:09 PDT 2018

kristina added inline comments.

Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:58
 // CHECK-NEXT: IFunc (SubjectMatchRule_function)
+// CHECK-NEXT: InitPriority (SubjectMatchRule_variable)
 // CHECK-NEXT: InternalLinkage (SubjectMatchRule_variable, SubjectMatchRule_function, SubjectMatchRule_record)
Adding remark about `init_priority` as an inline comment. Wouldn't make sense semantically as it defeats the point of explicitly specifying static init order and cause a clash instead and causes ordering to become undefined again (as well as issuing a diagnostic I think).

  rC Clang


More information about the cfe-commits mailing list