[PATCH] D51333: Diagnose likely typos in include statements

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 30 14:09:26 PDT 2018


rsmith added a comment.

Instead of guessing whether the corrected filename would be valid, why not strip off the leading and trailing non-alphanumeric characters, look up the resulting filename, and find out? If we did that, then not only could we be a lot more confident that we'd found the file that was intended, but we could also recover from the error by including the trimmed filename.


https://reviews.llvm.org/D51333





More information about the cfe-commits mailing list