[PATCH] D51473: Improve attribute documentation to list which spellings are used in which syntaxes.

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 30 12:21:48 PDT 2018

rsmith marked an inline comment as done.
rsmith added inline comments.

Comment at: utils/TableGen/ClangAttrEmitter.cpp:3881
+    SpellingKind K = (SpellingKind)Kind;
+    // FIXME: Why are Microsoft spellings not listed?
+    if (K == SpellingKind::Microsoft)
aaron.ballman wrote:
> We don't actually support Microsoft's attribute spellings currently and have no attributes there to document. I think the fixme should probably read "TODO: support documenting Microsoft spellings" or something more concrete.
Done. (I accidentally pushed the old version, so this is done in r341100.)

For what it's worth, we have one `Microsoft` spelling listed in the .td file already (but I assume this has no effect):

def Uuid : InheritableAttr {
  let Spellings = [Declspec<"uuid">, Microsoft<"uuid">];



More information about the cfe-commits mailing list