[PATCH] D50845: [CUDA/OpenMP] Define only some host macros during device compilation

Gheorghe-Teodor Bercea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 30 11:34:25 PDT 2018

gtbercea added a comment.

In https://reviews.llvm.org/D50845#1219709, @tra wrote:

> FYI. This breaks our CUDA compilation. I haven't figured out what exactly is wrong yet. I may need to unroll the patch if the fix is not obvious.

Agreed. Patches https://reviews.llvm.org/D51446 and https://reviews.llvm.org/D51312 apply fixes for the PPC64 toolchain. Similar fixes are needed for other architectures probably.
In general, it looks like this patch leads to some host macros having to be defined again for the auxiliary triple case. It is not clear to me how to exhaustively identify the missing macros, so far it's been just trial and error.



More information about the cfe-commits mailing list