[PATCH] D51473: Improve attribute documentation to list which spellings are used in which syntaxes.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 30 11:10:13 PDT 2018

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a commenting nit. Thank you for this, I like this exposition better!

Comment at: utils/TableGen/ClangAttrEmitter.cpp:3881
+    SpellingKind K = (SpellingKind)Kind;
+    // FIXME: Why are Microsoft spellings not listed?
+    if (K == SpellingKind::Microsoft)
We don't actually support Microsoft's attribute spellings currently and have no attributes there to document. I think the fixme should probably read "TODO: support documenting Microsoft spellings" or something more concrete.

  rC Clang


More information about the cfe-commits mailing list