[PATCH] D51426: [Sema] Prohibit function-scope compound literals with address spaces.

Bevin Hansson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 29 23:59:19 PDT 2018


ebevhan added inline comments.


================
Comment at: lib/Sema/SemaExpr.cpp:5745
+    // C99 6.5.2.5p6: Function scope compound literals must have automatic
+    // storage which generally excludes address space-qualified ones.
+    Diag(LParenLoc, diag::err_compound_literal_with_address_space)
----------------
rjmccall wrote:
> Usually when we mention a standard section like this, it's a prelude to a quote.  If you're just paraphrasing, I think we can trust people to find the right standard section.
Hm, alright. I figured it was better to both provide the exact section and also include a summary here so you don't have to look it up.

Should I change it or is it good anyway?


Repository:
  rC Clang

https://reviews.llvm.org/D51426





More information about the cfe-commits mailing list