[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 29 14:30:49 PDT 2018
tra added inline comments.
================
Comment at: lib/Driver/ToolChains/HIP.cpp:255
+ options::OPT_fvisibility_ms_compat)) {
+ CC1Args.push_back("-fvisibility");
+ CC1Args.push_back("hidden");
----------------
Nit: You could collapse multiple `push_back` calls into a single `append({...})`:
`CC1Args.append({"-fvisibility", "hidden"});`
https://reviews.llvm.org/D51434
More information about the cfe-commits
mailing list