[PATCH] D51434: [HIP] Add -amdgpu-internalize-symbols option to opt

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 29 12:21:34 PDT 2018

arsenm added a comment.

In https://reviews.llvm.org/D51434#1218017, @yaxunl wrote:

> In https://reviews.llvm.org/D51434#1217971, @arsenm wrote:
> > https://reviews.llvm.org/D51209 is the patch. I think HIP will need an additional patch, since I think it isn’t subclassing the amdgpu toolchain
> Yes since HIP has different toolchain. This does not affect kernel's visibility, right?

It does, but the visibility of the kernel shouldn't matter


More information about the cfe-commits mailing list