[PATCH] D51416: [RTTI] Align rtti type string to prevent over-alignment

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 29 11:53:54 PDT 2018

efriedma added a comment.

Could we make CreateOrReplaceCXXRuntimeVariable take the alignment as an argument, so we can be sure we're consistently setting the alignment for these variables?  This seems easy to mess up if we're scattering calls all over the place.

Sort of orthogonal, but CreateOrReplaceCXXRuntimeVariable should probably also call setUnnamedAddr, instead of making each caller call it.


More information about the cfe-commits mailing list