[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 29 10:59:54 PDT 2018

mstorsjo added a comment.

In https://reviews.llvm.org/D51440#1217839, @manojgupta wrote:

> Just a minor comment regarding test cases: Since you are adding both -L/path/ and -l<libname>,  the test cases should be updated to  check for the -L/path/ argument as well.

I guess I could do that, although we don't know the path in the test, so we can only check for `-L.*`.

In https://reviews.llvm.org/D51440#1217868, @lebedev.ri wrote:

> Since the libraries will no longer be specified with their full path, how will you know that the **right** library will be picked, the one compiler intended?

We don't; the same goes for libgcc. I guess the risk for unintentional clashes is rather low; if the linker found another lib with the same name, I would expect it to be intentional, and using it wouldn't be wrong.

  rC Clang


More information about the cfe-commits mailing list