[PATCH] D51381: [clang-tidy] fix check_clang_tidy to properly mix CHECK-NOTES and CHECK-MESSAGES

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 28 23:15:06 PDT 2018

lebedev.ri added a comment.

You would still have to duplicate the check-lines for `error:` though.

As it was discussed in https://reviews.llvm.org/D36892 i would think the current behavior is correct:
the `CHECK-MESSAGES` vs `CHECK-NOTES` denotes the severity of the output msg that is ok to be ignored.
If you are ok with ignoring notes, just use the `CHECK-MESSAGES` prefix.
If you want the notes to be checked, use `CHECK-NOTES` prefix.
Either/or. But don't mix them.

It's not a good idea to mix them, e.g. because the tool then has to run FileCheck twice..

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list