[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

Raphael Isemann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 28 10:55:48 PDT 2018

teemperor marked 3 inline comments as done.
teemperor added inline comments.

Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:6
+#include "libc-empty-except.h"
+void f() {
bruno wrote:
> In a testcase like this but using the actual real headers, if you do:
> #include <xmmintrin.h>
> #include <stdlib.h>
> does it also compiles fine?
(I already answered this offline back then, but for the record again): Yes, we tried this actual code and I think the test case (with the actual reverse fix applied) also should cover this case.

Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:27
+#include "mm_malloc.h"
+#include "stdlib.h"
v.g.vassilev wrote:
> Maybe we should reverse the includes here as we discussed offline.


More information about the cfe-commits mailing list