[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 28 08:15:24 PDT 2018
hokein added inline comments.
================
Comment at: test/clang-tidy/Inputs/absl/external-file.h:1
+void DirectAcess2() { absl::strings_internal::InternalFunction(); }
+
----------------
The file can not self-compile, and we should make it compilable.
And put the newly-added code at the end of the file, so that other test file can keep unchanged.
================
Comment at: test/clang-tidy/Inputs/absl/strings/internal-file.h:34
+} // namespace absl
+
----------------
nit: remove the empty line.
https://reviews.llvm.org/D50542
More information about the cfe-commits
mailing list