[PATCH] D51332: [clang-tidy] Replace deprecated std::ios_base aliases

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 28 00:57:34 PDT 2018

JonasToth added a comment.

Hi andobence,

thank you for the contribution. The check looks very good!
Please add it to the release notes and synchronize the first line of the doc with the short sentence in the release notes describing what this check does.

Comment at: clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.h:20
+/// This check warns the uses of the deprecated member types of ``std::ios_base``
+/// and replaces those that have a non - deprecated equivalent.
I I think you can write `non-deprecated` without the whitespace.

Comment at: test/clang-tidy/modernize-deprecated-ios-base-aliases.cpp:14
+template <
+    class CharT>
That format looks weird. Could you please run clang-format over the test as well?

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list