[PATCH] D51265: Headers: fix collisions with .h files of other projects

Andrew Kelley via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 27 20:50:19 PDT 2018


andrewrk marked an inline comment as done.
andrewrk added a comment.

In https://reviews.llvm.org/D51265#1215060, @efriedma wrote:

> What is this change actually solving?  Even if the typedef is actually redundant, it shouldn't cause a compiler error: redundant typedefs are allowed in the latest versions of the C and C++ standards. (And even if you were targeting an earlier standard, we normally suppress warnings in system headers.)


Here's an example use case that this solves:

- Install MXE (See https://mxe.cc/)
- Install the png package
- Use libclang API to parse png.h
- Expect that there are no errors, but there are errors


Repository:
  rC Clang

https://reviews.llvm.org/D51265





More information about the cfe-commits mailing list