[PATCH] D51314: Parse compile commands lazily in InterpolatingCompilationDatabase

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 27 09:45:24 PDT 2018


ilya-biryukov added inline comments.


================
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:440
       Result.emplace_back(std::move(Command));
-      if (Result.back().Type == types::TY_INVALID)
-        Result.pop_back();
----------------
We can't look at 'Type' at this point anymore, because it needs parsing of TranserableCommands. Not sure what's the best way to replace it. @sammccall, any ideas?



Repository:
  rC Clang

https://reviews.llvm.org/D51314





More information about the cfe-commits mailing list