[PATCH] D51265: Headers: fix collisions with .h files of other projects

Josh Junon via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 25 20:10:31 PDT 2018


Qix- added inline comments.


================
Comment at: lib/Headers/stdarg.h:30
 #ifndef _VA_LIST
+#ifndef _VA_LIST_T
 typedef __builtin_va_list va_list;
----------------
Super nit-picky but you could condense this a bit by using

```
#if !defined(_VA_LIST) && !defined(_VA_LIST_T)
```

and a single `#endif` (revert the addition of line 34).

It's arguably easier to understand intent instead of adding another level of nesting. Same thing goes for the other two sections.

Just a suggestion.


Repository:
  rC Clang

https://reviews.llvm.org/D51265





More information about the cfe-commits mailing list