[PATCH] D50845: [CUDA/OpenMP] Define only some host macros during device compilation

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 25 06:42:36 PDT 2018


Hahnfeld added a comment.

In https://reviews.llvm.org/D50845#1212643, @tra wrote:

> Please keep an eye on CUDA buildbot http://lab.llvm.org:8011/builders/clang-cuda-build.
>  It runs fair amount of tests with libc++ and handful of libstdc++ versions and may a canary if these changes break something.


I just tested locally and `std::remainder` fails with CUDA 8.0.44 when compiling for `c++11` or later - both with and without this patch. My guess is that this version has a bug because all tests pass with CUDA 9.2.88.

I'll land this change now and watch the buildbot for any problems, thanks.


https://reviews.llvm.org/D50845





More information about the cfe-commits mailing list