[PATCH] D51229: [Sema/Attribute] Make types declared with address_space an AttributedType

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 24 18:54:34 PDT 2018


rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Sema/SemaType.cpp:5600-5605
     if (DependentAddressSpaceTypeLoc DASTL =
         CurrTL.getAs<DependentAddressSpaceTypeLoc>()) {
       fillDependentAddressSpaceTypeLoc(DASTL, D.getTypeObject(i).getAttrs());
       CurrTL = DASTL.getPointeeTypeLoc().getUnqualifiedLoc();
     }
 
----------------
Can you delete this, or otherwise reorder the filling of dependent address spaces, atomic types, attributed types, and adjusted types so that we don't have duplicates?


Repository:
  rC Clang

https://reviews.llvm.org/D51229





More information about the cfe-commits mailing list