[PATCH] D51084: Implement -Watomic-implicit-seq-cst

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 24 17:40:43 PDT 2018


rjmccall added inline comments.


================
Comment at: lib/Sema/SemaChecking.cpp:10668
+  if (Source->isAtomicType() || Target->isAtomicType())
+    S.Diag(E->getBeginLoc(), diag::warn_atomic_implicit_seq_cst);
+
----------------
Why would the target be an atomic type?  And if it is an atomic type, isn't that an initialization of a temporary?  In what situation does it make sense to order the initialization of a temporary?


Repository:
  rC Clang

https://reviews.llvm.org/D51084





More information about the cfe-commits mailing list