[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tidy/abseil/RedundantStrcatCallsCheck.cpp:28
+
+void RedundantStrcatCallsCheck::registerMatchers(MatchFinder* Finder) {
+  if (!getLangOpts().CPlusPlus) 
----------------
aaron.ballman wrote:
> The formatting here looks off -- you should run the patch through clang-format, if you haven't already.
This comment is marked done but the formatting in the patch still doesn't match the LLVM coding style. For instance, pointers bind to the right, not to the left in our style.


================
Comment at: clang-tidy/abseil/RedundantStrcatCallsCheck.cpp:135
+  diag(RootCall->getBeginLoc(), 
+  	   "multiple calls to 'StrCat' can be flattened into a single call")
+      << CheckResult.Hints;
----------------
One more change, based on comments in other reviews, this should probably be `'absl::StrCat'` instead of just `'StrCat'`.


https://reviews.llvm.org/D51132