[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a subscriber: sammccall.
ilya-biryukov added inline comments.


================
Comment at: clangd/tool/ClangdMain.cpp:197
 
+static llvm::cl::opt<bool> IncludeFixIts(
+    "include-fixits",
----------------
I wonder if we should make the `IncludeFixIts` option hidden?
It currently only works for our YCM integration, VSCode and other clients break.


================
Comment at: clangd/tool/ClangdMain.cpp:198
+static llvm::cl::opt<bool> IncludeFixIts(
+    "include-fixits",
+    llvm::cl::desc(
----------------
This is a bit too generic name for the binary. Maybe `-completion-fixits`?


================
Comment at: clangd/tool/ClangdMain.cpp:202
+        "Like changing an arrow(->) member access to dot(.) member access."),
+    llvm::cl::init(clangd::CodeCompleteOptions().IncludeFixIts));
+
----------------
Maybe specify the value here explicitly?
The defaults for users of the clangd binary (what the option is for) is not necessarily the best default for the `ClangdServer` clients (what the default in the struct is for).
More importantly, it's useful to be more straightforward about the defaults we have for the options.


================
Comment at: clangd/tool/ClangdMain.cpp:205
+static llvm::cl::opt<bool> EnableFunctionArgSnippets(
+    "enable-function-arg-snippets",
+    llvm::cl::desc("Gives snippets for function arguments, when disabled only "
----------------
I wonder if we can infer this setting from the `-completion-style' (`=bundled` implies `enable-function-arg-snippets == false`)
@sammccall, WDYT?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51214