[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 23 10:21:23 PDT 2018


Eugene.Zelenko added inline comments.


================
Comment at: docs/clang-tidy/checks/abseil-redundant-strcat-calls.rst:16
+
+	string s = absl::StrCat("A", absl::StrCat("B", absll::StrCat("C", "D")));
+  	    string s = absl::StrCat("A", "B", "C", "D");
----------------
std::string. Please insert empty line.


================
Comment at: docs/clang-tidy/checks/abseil-redundant-strcat-calls.rst:17
+	string s = absl::StrCat("A", absl::StrCat("B", absll::StrCat("C", "D")));
+  	    string s = absl::StrCat("A", "B", "C", "D");
+	absl::StrAppend(&s, absl::StrCat("E", "F", "G"));
----------------
std::string. Same indentation as in previous line. Same for second example.


https://reviews.llvm.org/D51132





More information about the cfe-commits mailing list