[PATCH] D51155: [clangd] Allow to merge symbols on-the-fly in global-symbol-builder

[Eric Liu via Phabricator via cfe-commits]

ioeric added a comment.

Overall looks good to me.



================
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:61
+    /// rely on MR use-case to work properly.
+    llvm::cl::init(false));
+
----------------
AFAIK, this flag would basically depend on the executor being used. If executor can provide information like whether all tasks share memory, we can make the decision totally based on the selected executor (i.e. one fewer option).


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51155