[PATCH] D50898: [clangd] Suggest code-completions for overriding base class virtual methods.

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM.



================
Comment at: clangd/CodeComplete.cpp:210
+    const std::string Name = Method->getNameAsString();
+    Overrides[Name].push_back(Method);
+  }
----------------
nit: here as well, use `Overrides[Method->getName()].push_back...`


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50898