r340466 - [ASTImporter] Remove duplicated and dead CXXNamedCastExpr handling code.
Raphael Isemann via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 22 15:49:32 PDT 2018
Author: teemperor
Date: Wed Aug 22 15:49:32 2018
New Revision: 340466
URL: http://llvm.org/viewvc/llvm-project?rev=340466&view=rev
Log:
[ASTImporter] Remove duplicated and dead CXXNamedCastExpr handling code.
Summary:
`CXXNamedCastExpr` importing is already handled in the respective `VisitCXXNamedCastExpr` method.
So this code here can never be reached under normal circumstances and we might as well remove it.
This patch shouldn't change any observable behavior of the ASTImporter.
Reviewers: a.sidorin, a_sidorin
Reviewed By: a_sidorin
Subscribers: martong, cfe-commits
Differential Revision: https://reviews.llvm.org/D51110
Modified:
cfe/trunk/lib/AST/ASTImporter.cpp
Modified: cfe/trunk/lib/AST/ASTImporter.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTImporter.cpp?rev=340466&r1=340465&r2=340466&view=diff
==============================================================================
--- cfe/trunk/lib/AST/ASTImporter.cpp (original)
+++ cfe/trunk/lib/AST/ASTImporter.cpp Wed Aug 22 15:49:32 2018
@@ -6088,38 +6088,6 @@ Expr *ASTNodeImporter::VisitExplicitCast
TInfo, SubExpr);
}
default:
- break; // just fall through
- }
-
- auto *Named = cast<CXXNamedCastExpr>(E);
- SourceLocation ExprLoc = Importer.Import(Named->getOperatorLoc()),
- RParenLoc = Importer.Import(Named->getRParenLoc());
- SourceRange Brackets = Importer.Import(Named->getAngleBrackets());
-
- switch (E->getStmtClass()) {
- case Stmt::CXXStaticCastExprClass:
- return CXXStaticCastExpr::Create(Importer.getToContext(), T,
- E->getValueKind(), E->getCastKind(),
- SubExpr, &BasePath, TInfo,
- ExprLoc, RParenLoc, Brackets);
-
- case Stmt::CXXDynamicCastExprClass:
- return CXXDynamicCastExpr::Create(Importer.getToContext(), T,
- E->getValueKind(), E->getCastKind(),
- SubExpr, &BasePath, TInfo,
- ExprLoc, RParenLoc, Brackets);
-
- case Stmt::CXXReinterpretCastExprClass:
- return CXXReinterpretCastExpr::Create(Importer.getToContext(), T,
- E->getValueKind(), E->getCastKind(),
- SubExpr, &BasePath, TInfo,
- ExprLoc, RParenLoc, Brackets);
-
- case Stmt::CXXConstCastExprClass:
- return CXXConstCastExpr::Create(Importer.getToContext(), T,
- E->getValueKind(), SubExpr, TInfo, ExprLoc,
- RParenLoc, Brackets);
- default:
llvm_unreachable("Cast expression of unsupported type!");
return nullptr;
}
More information about the cfe-commits
mailing list