[PATCH] D49885: Thread safety analysis: Allow relockable scopes
Aaron Puchert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 22 15:35:09 PDT 2018
aaronpuchert added inline comments.
================
Comment at: lib/Analysis/ThreadSafety.cpp:932
+ // We're relocking the underlying mutexes. Warn on double locking.
+ if (FSet.findLock(FactMan, UnderCp))
+ Handler.handleDoubleLock(DiagKind, UnderCp.toString(), entry.loc());
----------------
delesley wrote:
> Minor nit. Use curly braces on the if, to match the else.
Removing the braces [was suggested](https://reviews.llvm.org/D49885?id=157599#inline-439256) by @aaron.ballman in an earlier patch set, but I can just add them in again. I slightly favor having them, but I don't feel strongly either way.
Repository:
rL LLVM
https://reviews.llvm.org/D49885
More information about the cfe-commits
mailing list