[PATCH] D51061: [clang-tidy] abseil-str-cat-append

[Hugo Gonzalez via Phabricator via cfe-commits]

hugoeg added inline comments.


================
Comment at: test/clang-tidy/abseil-str-cat-append.cpp:91
+
+void bar() {
+  std::string a, b;
----------------
JonasToth wrote:
> What happens if `StrCat` is used e.g. in an `std::accumulate` call as the binary operator? (https://en.cppreference.com/w/cpp/algorithm/accumulate  the Example includes such a case)
> Is this diagnosed, too?
> 
> The general case would be if `StrCat` is used as a template argument for a functor.
it doesn't diagnose those cases. and diagnosing it doesn't seem to be worthwhile


https://reviews.llvm.org/D51061