[PATCH] D51088: [clangd] Get rid of regexes in CanonicalIncludes

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.


================
Comment at: clangd/index/CanonicalIncludes.h:44
   /// Maps all files matching \p RE to \p CanonicalPath
-  void addRegexMapping(llvm::StringRef RE, llvm::StringRef CanonicalPath);
+  void addSuffixMapping(llvm::StringRef Suffix, llvm::StringRef CanonicalPath);
 
----------------
ioeric wrote:
> It seems that this is only file path suffix matching (by components) now. We should probably rename the function to be explicit.
Renamed to addPathSuffixMapping, updated the doc.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51088