[PATCH] D50926: [SourceManager] Extract 'findFileIDsForFile' from 'translateFile' to allow mapping from one file entry to multiple FileIDs

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 22 04:06:51 PDT 2018


ioeric added inline comments.


================
Comment at: lib/Basic/SourceManager.cpp:1705
 
   // If we haven't found what we want yet, try again, but this time stat()
   // each of the files in case the files have changed since we originally
----------------
arphaman wrote:
> ioeric wrote:
> > Do we also need this in `findFileIDsForFile`?
> I don't really need this for my use case.
But it's not clear from the interface AFAICT. We should either handle this case (maybe controlled with a flag), or make it clear in the API (with a different name or documentation).


Repository:
  rC Clang

https://reviews.llvm.org/D50926





More information about the cfe-commits mailing list