[PATCH] D50970: [clangd] Implement BOOST iterator

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 22 02:36:03 PDT 2018


kbobyrev updated this revision to Diff 161909.
kbobyrev marked 4 inline comments as done.
kbobyrev added a subscriber: sammccall.
kbobyrev added a comment.

- Add more comments explaining the difference between `consume()` and `consumeAndBoost()` and their potential usecases for the clients
- Move `DEFAULT_BOOSTING_SCORE` to the header by making it `constexpr` and change its type to `float`


https://reviews.llvm.org/D50970

Files:
  clang-tools-extra/clangd/index/dex/Iterator.cpp
  clang-tools-extra/clangd/index/dex/Iterator.h
  clang-tools-extra/unittests/clangd/DexIndexTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50970.161909.patch
Type: text/x-patch
Size: 13790 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180822/fa5a277f/attachment.bin>


More information about the cfe-commits mailing list