[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

Maybe add tests? Lit tests for code completion (`clang/test/CodeCompletion`) should be a good fit



================
Comment at: include/clang/Parse/Parser.h:2971
+  /// signature help working even when it is triggered inside a token.
+  bool CalledOverloadCompletion = false;
 };
----------------
Maybe put the field closer to the existing ones?


================
Comment at: lib/Parse/ParseExpr.cpp:2820
         Actions.CodeCompleteOrdinaryName(getCurScope(), Sema::PCC_Expression);
+      CalledOverloadCompletion = true;
       cutOffParsing();
----------------
Why should we set this flag here? Can it be handled by `Completer` function that we pass into `ParseExperssionList` instead?


Repository:
  rC Clang

https://reviews.llvm.org/D51038