[PATCH] D51041: [clang-tidy] Don't run misc-unused-using-decls check in C++17.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 22 00:58:06 PDT 2018
hokein marked an inline comment as done.
hokein added inline comments.
================
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:35
+ // it is not ture in C++17's template argument deduction.
+ if (!getLangOpts().CPlusPlus || getLangOpts().CPlusPlus17 ||
+ getLangOpts().CPlusPlus2a)
----------------
xazax.hun wrote:
> Isn't the check for `getLangOpts().CPlusPlus2a` redundant? Shouldn't it imply the C++17 flag?
Didn't notice it. Yeah, you are right. If `CPlusCplus2a` also indicates C++17.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51041
More information about the cfe-commits
mailing list