[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS
Dmitry via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 22 00:16:07 PDT 2018
Dmitry.Kozhevnikov added a comment.
In https://reviews.llvm.org/D50993#1207757, @jfb wrote:
> Isn't this duplicating code in lib/Support/Unix/Threading.inc with a different implementation?
It's definitely duplicating how the thread is created, however, here it's a bit more complicated as some dance with the passed function lifetime is required, while `llvm_execute_on_thread` just uses a local variable since it blocks till the thread is terminated.
Still, I see that it's desirable to have the new code in Support/Threading, I'll move it there.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50993
More information about the cfe-commits
mailing list