[PATCH] D50580: [clang-tidy] Abseil: no namespace check

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 21 10:03:21 PDT 2018


Eugene.Zelenko added a comment.

Please rebase from trunk.



================
Comment at: docs/ReleaseNotes.rst:63
+
+  Checks to ensure code does not open `namespace absl` as that
+  violates Abseil's compatibility guidelines.
----------------
Just Ensures. Please use `` for language constructs.


================
Comment at: docs/clang-tidy/checks/abseil-no-namespace.rst:6
+
+This check gives users a warning if they attempt to open ``namespace absl``.
+Users should not open ``namespace absl`` as that conflicts with abseil's
----------------
Please synchronize first sentence with Release Notes.


================
Comment at: docs/clang-tidy/checks/abseil-no-namespace.rst:7
+This check gives users a warning if they attempt to open ``namespace absl``.
+Users should not open ``namespace absl`` as that conflicts with abseil's
+compatibility guidelines and may result in breakage.
----------------
Abseil


================
Comment at: docs/clang-tidy/checks/abseil-no-namespace.rst:10
+
+Any user that uses:
+
----------------
Code instead of user, please.


================
Comment at: docs/clang-tidy/checks/abseil-no-namespace.rst:20
+
+See `the full Abseil compatibility guidelines <https: //
+abseil.io/about/compatibility>`_ for more information.
----------------
Please remove space after https:


https://reviews.llvm.org/D50580





More information about the cfe-commits mailing list