[PATCH] D50889: [clangd] Make FileIndex aware of the main file

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 21 07:40:06 PDT 2018


ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.

All the issues should be addressed at this point



================
Comment at: clangd/ClangdServer.cpp:70
+// FIXME(ibiryukov): this should be a generic helper instead.
+class NoopCallbacks : public ParsingCallbacks {
 public:
----------------
ilya-biryukov wrote:
> ioeric wrote:
> > Maybe provide noop implementations for `ParsingCallbacks::onPreambleAST()` and `ParsingCallbacks::onMainAST` by default?
> I'll address this in a parent revision. 
Done


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50889





More information about the cfe-commits mailing list